[proposal] Use rust based cp tool rather than busybox in autoinstrumentation images.
#1698
+751
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have added @rapphil as a codeowner also. He was the primary author of the rust |
jaronoff97
reviewed
May 2, 2023
| @@ -20,3 +20,6 @@ | |||
|
|
|||
| # Target Allocator owners | |||
| cmd/otel-allocator @open-telemetry/operator-ta-maintainers | |||
|
|
|||
| # cp-utility tool | |||
| tools/cp-utility @rapphil @bryan-aguilar | |||
There was a problem hiding this comment.
we'll have to make another group in order to use CODEOWNERS here
frzifus
reviewed
May 11, 2023
| FROM busybox | ||
|
|
||
| # Stage 1: Build the cp-utility binary | ||
| FROM rust:1.69 as builder |
There was a problem hiding this comment.
can the rust cp impl. be built for all target platforms supported by go? What I have in mind are ibm z + power (that's what we have to support).
There was a problem hiding this comment.
yes, s390x and ppc64le are supported by the rust base image and musl.
Are you using the autoinstrumentation images that are published from this repo in those platforms? I'm asking because today they only support arm and x86 (please take a look here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1600
Apologies for this taking so long. As mentioned in the issue we would like to propose a replacement to the busybox base image used in the auto-instrumentation images. This PR is a demonstration on what that implementation would look like for a single auto-instrumentation images. If this proposal is accepted followup PRs would be made to adjust the remaining dockerfiles and github workflows.
The Rust based CP tool is statically linked to MUSL, which is licensed under MIT license. This implementation handles all the cases currently required by the Operator auto-instrumentation images: regular file copy (used in the Java) and archive copy (used in Python and NodeJS).
This is currently in use in our ADOT Java Instrumentation agent. Dockerfile ref.
Please feel free to ask any follow up questions. I will ensure this is brought up in the next sig meeting.